-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Attention nets PyTorch support and cleanup (using traj. view API). #12029
Merged
ericl
merged 185 commits into
ray-project:master
from
sven1977:attention_nets_pytorch_cleanup
Dec 22, 2020
Merged
[RLlib] Attention nets PyTorch support and cleanup (using traj. view API). #12029
ericl
merged 185 commits into
ray-project:master
from
sven1977:attention_nets_pytorch_cleanup
Dec 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectory_view_api_attention_nets
…nto trajectory_view_api_attention_nets # Conflicts: # rllib/models/tf/attention_net.py # rllib/policy/view_requirement.py
…ectory_view_api_enable_by_default_for_all_simple
…ectory_view_api_attention_nets
…ectory_view_api_enable_by_default_for_all_simple
sven1977
changed the title
[ONHOLD RLlib] Attention nets PyTorch support and cleanup (using traj. view API).
[RLlib] Attention nets PyTorch support and cleanup (using traj. view API).
Dec 17, 2020
sven1977
removed
the
@author-action-required
The PR author is responsible for the next step. Remove tag to send back to the reviewer.
label
Dec 17, 2020
ericl
added
the
@author-action-required
The PR author is responsible for the next step. Remove tag to send back to the reviewer.
label
Dec 17, 2020
(other PR doesn't seem merged yet) |
…ntion_nets_pytorch_cleanup # Conflicts: # rllib/evaluation/collectors/simple_list_collector.py # rllib/policy/eager_tf_policy.py # rllib/policy/tf_policy.py
sven1977
removed
the
@author-action-required
The PR author is responsible for the next step. Remove tag to send back to the reviewer.
label
Dec 21, 2020
ericl
approved these changes
Dec 21, 2020
rllib/policy/tf_policy_template.py:19:5: F401 'ray.rllib.evaluation.episode.MultiAgentEpisode' imported but unused //rllib:tests/test_lstm FAILED in 3 out of 3 in 31.9s |
ericl
added
the
@author-action-required
The PR author is responsible for the next step. Remove tag to send back to the reviewer.
label
Dec 21, 2020
…ntion_nets_pytorch_cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@author-action-required
The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attention Nets:
Why are these changes needed?
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.