Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Attention nets PyTorch support and cleanup (using traj. view API). #12029

Merged
merged 185 commits into from
Dec 22, 2020

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Nov 15, 2020

Attention Nets:

  • full PyTorch support
  • using traj. view API

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977 sven1977 changed the title [ONHOLD RLlib] Attention nets PyTorch support and cleanup (using traj. view API). [RLlib] Attention nets PyTorch support and cleanup (using traj. view API). Dec 17, 2020
@sven1977 sven1977 removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Dec 17, 2020
@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Dec 17, 2020
@ericl
Copy link
Contributor

ericl commented Dec 17, 2020

(other PR doesn't seem merged yet)

@sven1977 sven1977 removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Dec 21, 2020
@ericl
Copy link
Contributor

ericl commented Dec 21, 2020

rllib/policy/tf_policy_template.py:19:5: F401 'ray.rllib.evaluation.episode.MultiAgentEpisode' imported but unused
rllib/policy/torch_policy.py:26:5: F401 'ray.rllib.evaluation.episode.MultiAgentEpisode' imported but unused

//rllib:tests/test_lstm FAILED in 3 out of 3 in 31.9s

@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Dec 21, 2020
@ericl ericl merged commit d5604ea into ray-project:master Dec 22, 2020
cathrinS pushed a commit to cathrinS/ray that referenced this pull request Dec 29, 2020
@sven1977 sven1977 deleted the attention_nets_pytorch_cleanup branch March 27, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants