[autoscaler] Fix worker capping fifo test in new scheduler #12512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuisawesome
approved these changes
Dec 1, 2020
|
Test still failing |
ericl
added
the
@author-action-required
|
Still failing |
|
Still seems failing due to travis not starting 3 workers when num_cpus=3 somehow. I'm inclined to remove this test since it's inherently brittle, and should be unit tested instead (though not sure if we currently have such a unit test). @kfstorm does this sound ok? |
|
@ericl It sounds good to me. But can you add a test in |
|
@kfstorm I don't have the bandwidth to do that, we can also ignore the test for now and go ahead with the new scheduler regardless |
|
@ericl OK, I'll add the test into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new scheduler, workers are popped more aggressively. This isn't incorrect, but breaks the test. Fix the test by changing the condition to be a bit more relaxed.
Closes #12435