Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dmitri/k8s command runner home try again #12609

Conversation

DmitriGekhtman
Copy link
Contributor

Why are these changes needed?

Un-reverts #12417,
see #12607 .

(Added underscore in _home method to fix test_command_runner)

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@edoakes edoakes merged commit f61bc79 into ray-project:master Dec 8, 2020
@DmitriGekhtman DmitriGekhtman deleted the dmitri/k8s-command-runner-home-try-again branch January 1, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants