Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[K8s] Retry getting home directory in command runner. #12925

Merged
merged 3 commits into from
Dec 17, 2020

Conversation

DmitriGekhtman
Copy link
Contributor

@DmitriGekhtman DmitriGekhtman commented Dec 16, 2020

Why are these changes needed?

Related issue number

Closes #12883

Works towards #12924

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

I've tested locally that these changes don't mess up ray up or ray rsync_ with ~ in the remote path.
Testing that this actually solves the problem will require more work (see #12924).

Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks good!

@DmitriGekhtman DmitriGekhtman added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Dec 17, 2020
@richardliaw richardliaw merged commit 82f9c70 into ray-project:master Dec 17, 2020
@DmitriGekhtman DmitriGekhtman deleted the dmitri/k8s_home_retry branch January 1, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[k8s] printenv occasionally fails
3 participants