Revert "Revert "Enable Ray client server by default (#13350)" (#13429)" #13442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…" (ray-project#13429)" This reverts commit 5602999.
|
@AmeerHajAli would you have any idea why enabling a new service on port 10001 breaks the cpp:cluster_mode_test? |
|
I am not sure. @kfstorm / @SongGuyang , do you have any idea why? |
|
I have no idea. @SongGuyang do you? |
|
@ericl Maybe because I have a hard code for node manager port? https://github.com/ray-project/ray/blob/master/cpp/include/ray/api/ray_config.h#L25 |
ericl
changed the title
|
Fixed; ptal |
ericl
added
the
tests-ok
rkooo567
approved these changes
Feb 2, 2021
fishbone
pushed a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
…" (ray-project#13429)" (ray-project#13442) * Revert "Revert "Enable Ray client server by default (ray-project#13350)" (ray-project#13429)" This reverts commit 5602999. * fix job id collision with ray client server
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
…ect#13350)" (ray-project#13429)" (ray-project#13442)" This reverts commit 41d4d56.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5602999.
Why are these changes needed?
The ray client server was causing the CPP mode test to fail; since it allocated jobid 1. The fix is to avoid using that job id.