Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Trajectory View API: Keep env infos (e.g. for postprocessing callbacks), no matter what. #13555

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Jan 19, 2021

Trajectory View API: Keep env infos (e.g. for postprocessing callbacks), no matter what.

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rhamnett
Copy link
Contributor

rhamnett commented Feb 8, 2021

Hi am currently affected by this, any chance we can merge?

@michaelzhiluo
Copy link
Contributor

@sven1977 It good to go, feel free to merge

@sven1977 sven1977 merged commit d7301a5 into ray-project:master Feb 9, 2021
@rhamnett
Copy link
Contributor

rhamnett commented Feb 9, 2021

@sven1977 thank you. How long does it take for this to be built into the 2.0.0 build whl?

fishbone pushed a commit to fishbone/ray that referenced this pull request Feb 16, 2021
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
…ocessing callbacks), no matter what. (ray-project#13555)"

This reverts commit 517472b.
@sven1977 sven1977 deleted the traj_view_api_keep_env_infos_for_callbacks branch June 2, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants