Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autoscaler] Display node status tag in autsocaler status #13561

Merged
merged 6 commits into from
Jan 21, 2021
Merged

[Autoscaler] Display node status tag in autsocaler status #13561

merged 6 commits into from
Jan 21, 2021

Conversation

wuisawesome
Copy link
Contributor

Why are these changes needed?

This PR displays the node status tag instead of just listing all nodes running ssh commands as being in "setting up".

In practice, I've found this to be useful in distinguishing between aws failures and setup commands hanging.

The change is essentially this output:

Pending:
 m4.4xlarge, 2 launching
- 1.2.3.4: m4.4xlarge, setting up
- 1.2.3.5: m4.4xlarge, setting up
+ 1.2.3.4: m4.4xlarge, waiting-for-ssh
+ 1.2.3.5: m4.4xlarge, waiting-for-ssh

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

AmeerHajAli
AmeerHajAli approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@AmeerHajAli AmeerHajAli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ericl
Copy link
Contributor

ericl commented Jan 19, 2021

LINT

@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jan 19, 2021
@wuisawesome wuisawesome added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. labels Jan 21, 2021
@ericl ericl merged commit b9ac387 into ray-project:master Jan 21, 2021
fishbone pushed a commit to fishbone/ray that referenced this pull request Feb 16, 2021
@fishbone
[Autoscaler] Display node status tag in autsocaler status (ray-projec…
1e852ed 
…t#13561)

* .

* .

* .

* .

* .

* lint

Co-authored-by: Alex Wu <alex@anyscale.com>
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
@fishbone
Revert "[Autoscaler] Display node status tag in autsocaler status (ra…
b549a4d 
…y-project#13561)"

This reverts commit 1e852ed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmeerHajAli AmeerHajAli AmeerHajAli approved these changes

Assignees

@ericl ericl

@AmeerHajAli AmeerHajAli

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wuisawesome @ericl @AmeerHajAli