[tune] add type hints to tune.run(), fix abstract methods of Progress… #13684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krfricke
commented
Jan 26, 2021
Comment on lines
+10
to
+20
| from ray.tune.callback import Callback | ||
| from ray.tune.error import TuneError | ||
| from ray.tune.experiment import Experiment, convert_to_experiment_list | ||
| from ray.tune.logger import Logger | ||
| from ray.tune.progress_reporter import CLIReporter, JupyterNotebookReporter, \ | ||
| ProgressReporter | ||
| from ray.tune.ray_trial_executor import RayTrialExecutor | ||
| from ray.tune.registry import get_trainable_cls | ||
| from ray.tune.stopper import Stopper | ||
| from ray.tune.suggest import BasicVariantGenerator, SearchAlgorithm, \ | ||
| SearchGenerator |
There was a problem hiding this comment.
All these are the same imports but sorted alphabetically
richardliaw
approved these changes
Jan 26, 2021
2 tasks
fishbone
pushed a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
…ProgressReporter (ray-project#13684)" This reverts commit d476365.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Reporter
Why are these changes needed?
Related issue number
Closes #13153
Checks
scripts/format.shto lint the changes in this PR.