Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Issue #13802: Enhance metrics for multiagent->count_steps_by=agent_steps setting. #14033

Merged
merged 10 commits into from
Mar 18, 2021
Merged

[RLlib] Issue #13802: Enhance metrics for multiagent->count_steps_by=agent_steps setting. #14033

merged 10 commits into from
Mar 18, 2021

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Feb 10, 2021 •
edited
Loading

Issue #13802: Enhance metrics for multiagent->count_steps_by=agent_steps setting:

  • Added two more keys to the info dict in results returned by Trainer.train(): AGENT_STEPS_SAMPLED_COUNTER = "num_agent_steps_sampled" and AGENT_STEPS_TRAINED_COUNTER = "num_agent_steps_trained".

Why are these changes needed?

Issue #13802

Related issue number

Closes #13802

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977 sven1977 mentioned this pull request Feb 10, 2021
Closed
@jsuarez5341
Copy link
Contributor

@sven1977 @michaelzhiluo Any chance of this being merged soon? It's a rather useful little feature.

@sven1977
Copy link
Contributor Author

Merging this today. @jsuarez5341 .

@sven1977 sven1977 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Mar 18, 2021
@sven1977 sven1977 merged commit c3a15ec into ray-project:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelzhiluo michaelzhiluo michaelzhiluo approved these changes

Assignees

@michaelzhiluo michaelzhiluo

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[rllib] Incorrect count_steps_by metrics
3 participants
@sven1977 @jsuarez5341 @michaelzhiluo