Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Issue #13507: Fix MB-MPO CartPole Env's reward function as well as MB-MPO running into a traj. view API related issue. #14037

Merged
merged 2 commits into from
Feb 11, 2021
Merged

[RLlib] Issue #13507: Fix MB-MPO CartPole Env's reward function as well as MB-MPO running into a traj. view API related issue. #14037

merged 2 commits into from
Feb 11, 2021

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Feb 10, 2021 •
edited
Loading

Issue #13507: Fix MB-MPO CartPole Env's reward function as well as MB-MPO running into a traj. view API related issue.

Why are these changes needed?

Issue #13507

Related issue number

Closes #13507

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977 sven1977 mentioned this pull request Feb 10, 2021
Closed
michaelzhiluo
michaelzhiluo approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@michaelzhiluo michaelzhiluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This intersects with the prior PR
#14036

@sven1977 sven1977 merged commit 4db8640 into ray-project:master Feb 11, 2021
fishbone pushed a commit to fishbone/ray that referenced this pull request Feb 16, 2021
@sven1977 @fishbone
[RLlib] Issue ray-project#13507: Fix MB-MPO CartPole Env's reward fun…
5dfdea2 
…ction as well as MB-MPO running into a traj. view API related issue. (ray-project#14037)
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
@fishbone
Revert "[RLlib] Issue ray-project#13507: Fix MB-MPO CartPole Env's re…
a5f28c0 
…ward function as well as MB-MPO running into a traj. view API related issue. (ray-project#14037)"

This reverts commit 5dfdea2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelzhiluo michaelzhiluo michaelzhiluo approved these changes

Assignees

@michaelzhiluo michaelzhiluo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[rllib] Wrong reward for MBMPO Cartpole?
2 participants
@sven1977 @michaelzhiluo