-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Add coin game env. Matrix social dilemma env. With tests and examples. #14208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this massive contribution! This looks really great!
Just a few changes required:
- Could you run the LINTer on your repo (some lines are too long)?
-
- $ cd ray
-
- $ ci/travis/format.sh
- Could you move the test cases into a new
examples/env/tests
dir? - Could you rename ipd_env.py into
iterated_prisoners_dilemma_env.py
? - Could you move the reward-uncertainty class in
examples/utils/wrappers.py
intorllib/env/wrappers/.
? - Could you rename
examples/vectorized_coin_game.py
intoexamples/coin_game.py
? - Could you rename
test_coin_game.py
intotest_non_vectorized_coin_game.py
?
About these 2 changes:
Currently the existing files are:
The two changes mentioned should produce the following:
Is that what you had in mind? Then do you mean to merge vectorized_coin_game_env.py and coin_game_env.py in a single file?
If not, then the following seems like a better refactoring to me:
What do you think? |
Sounds great, let's rename these according to your suggestion. |
I committed the changes @sven1977 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Manuscrit for this great contribution!
One more thing before we can merge: Could you check the LINT output again? There seems to be 3 list comprehensions that need to be fixed.
@Manuscrit no worries, I already fixed the LINT. Just waiting for all tests to pass now. ... |
@sven1977
Why are these changes needed?
Add coin game env. Matrix social dilemma env. With tests and examples.
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR. => Some stuff are much less readable now ;)