Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune] Improve BOHB/ConfigSpace dependency check #15064

Merged
merged 2 commits into from
Apr 2, 2021
Merged

[tune] Improve BOHB/ConfigSpace dependency check #15064

merged 2 commits into from
Apr 2, 2021

Conversation

krfricke
Copy link
Contributor

@krfricke krfricke commented Apr 1, 2021

Why are these changes needed?

Remove hard dependency for ConfigSpace on BOHB import

Related issue number

ray-project/tune-sklearn#198

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@krfricke krfricke added the tune Tune-related issues label Apr 1, 2021
@krfricke krfricke merged commit 8de66fc into ray-project:master Apr 2, 2021
@krfricke krfricke deleted the searcher-import branch April 2, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

Assignees

@richardliaw richardliaw

Labels
tune Tune-related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krfricke @richardliaw