Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serve] Move route to deployment options #15124

Merged
merged 11 commits into from
Apr 7, 2021

Conversation

edoakes
Copy link
Contributor

@edoakes edoakes commented Apr 5, 2021

Why are these changes needed?

Move the route_prefix option to @serve.deployment so it can be updated independently of the underlying code.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@zhe-thoughts
Copy link
Collaborator

@edoakes Do you mean "router"?

@edoakes
Copy link
Contributor Author

edoakes commented Apr 6, 2021

@zhe-thoughts no, I meant route (it's called http_prefix in this PR because I can't settle on a name for it yet :)). It's just moving the option from the @serve.ingress decorator to the @serve.deployment one so it can be updated, changed, etc.

@edoakes
Copy link
Contributor Author

edoakes commented Apr 6, 2021

@simon-mo thoughts on the naming for this option? Three options I can think of are: route_prefix, http_prefix, and path_prefix. path_prefix seems like it might be a bit confusing to some users (e.g., is it a filepath? is it a path to my model?). http_prefix is ok but kind of redundant and couldn't be used for another transport type in the future (not a hard requirement). I'm leaning towards route_prefix because it's most similar to the existing API.

@edoakes edoakes changed the title [WIP] Move route to deployment options [serve] Move route to deployment options Apr 6, 2021
@simon-mo
Copy link
Contributor

simon-mo commented Apr 6, 2021

How about just prefix?

Copy link
Contributor

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edoakes edoakes added this to the [serve] v2 API milestone Apr 7, 2021
@edoakes edoakes merged commit 195f818 into ray-project:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants