-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[serve] Move route to deployment options #15124
[serve] Move route to deployment options #15124
Conversation
@edoakes Do you mean "router"? |
…-route-to-deployment-options
@zhe-thoughts no, I meant route (it's called |
@simon-mo thoughts on the naming for this option? Three options I can think of are: |
…-route-to-deployment-options
How about just |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…-route-to-deployment-options
…-route-to-deployment-options
Why are these changes needed?
Move the route_prefix option to
@serve.deployment
so it can be updated independently of the underlying code.Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.