Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rllib] evaluation parallel to training check hotfix #15345

Merged
merged 3 commits into from
Apr 27, 2021
Merged

[rllib] evaluation parallel to training check hotfix #15345

merged 3 commits into from
Apr 27, 2021

Conversation

krfricke
Copy link
Contributor

Why are these changes needed?

cc @sven1977
cc @amogkam

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

sven1977
sven1977 approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @krfricke .

@sven1977
Copy link
Contributor

1 failing test:
Win //python/ray/tests:test_reference_counting (unrelated to the change)

@sven1977 sven1977 merged commit 2c11a1a into ray-project:master Apr 27, 2021
@krfricke krfricke deleted the rllib-hotfix branch September 22, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sven1977 sven1977 sven1977 approved these changes

Assignees

@sven1977 sven1977

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krfricke @sven1977 @richardliaw