-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[autoscaler][kubernetes] Helm chart #15614
Conversation
Before adding documentation, I could use some feedback on whether the configuration options exposed in values.yaml look sensible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DmitriGekhtman Is this file auto-generated or did you write this by hand:
python/ray/autoscaler/kubernetes/operator_configs/helm/ray/crds/cluster_crd.yaml
nice! |
@DmitriGekhtman the config options look very reasonable to me as a first cut! |
python/ray/autoscaler/kubernetes/operator_configs/helm/ray/values.yaml
Outdated
Show resolved
Hide resolved
python/ray/autoscaler/kubernetes/operator_configs/helm/ray/templates/raycluster.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just a couple suggestions.
This was copied from |
I've added the Now will add some tests and documentation. |
Not sure about the ideal protocol for versioning and distributing this chart. |
docs written -- this should be good for a final review. |
Docs generated from Build here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
@ijrsvt It's good to merge |
Why are these changes needed?
This PR adds a Helm chart to simplify deployment of the Ray operator.
For now, only basic configuration options are exposed -- we could later expose more configuration on user feedback.
UX:
Launching operator and cluster with default settings.
helm -n <namespace> install <release name> ./ray
For custom configuration values one, uses
-f <custom-values.yaml>
or--set <option>=value
.Can launch just operator, without Ray cluster using
--set operatorOnly=true
.Can create a RayCluster resource without the operator using
--set clusterOnly=true
:if the operator is already running, this is the way to create multiple ray clusters.
This PR also pins Ray images used in the Ray clusters to 1.3.0
The operator is still set to nightly for now, for better stability. There's comment in the helm chart noting this and the alternatives of using 1.3.0 or a specific Ray master commit.
Related issue number
Closes #12654
Mostly addresses #15222 (still using nightly operator image, for now)
Closes #15652
Checks
scripts/format.sh
to lint the changes in this PR.