-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tune] Adjust searcher sample bounds to match Tune API #15899
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardliaw
reviewed
May 21, 2021
richardliaw
approved these changes
May 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine but did not carefully review.
Can we add this note somewhere in the docstrings for the tune search space primitives? Perhaps as a changelog?
https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#directive-versionchanged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We're currently passing searcher bounds directly to search algorithms - however, while we e.g. define
randint
's upper bound to be exclusive, this is not the case for other search algorithms (e.g. Optuna).This PR adds a more thorough testing framework to check the sampling behavior of all our searchers. It makes sure that the sampled values from any searcher is within the bounds defined by the Tune search space API. It also checks that (at least for discrete values) the search space is sampled extensively (i.e. that the highest and lowest discrete values are sampled, too, so that we didn't cut off too much of the search space).
Related issue number
Closes #15593
Checks
scripts/format.sh
to lint the changes in this PR.