[RLlib] Upgrade RLlib regression test scripts to new testing tool. #16080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b_regression_test_scripts
6 tasks
sven1977
added
the
tests-ok
krfricke
approved these changes
May 28, 2021
release/rllib_tests/README.rst
Outdated
|
|
||
| Overview | ||
| -------- | ||
| There are ??? kinds of tests: |
release/rllib_tests/app_config.yaml
Outdated
Comment on lines
23
to
27
| #- sudo mkdir -p /data || true | ||
| #- sudo chown ray:1000 /data || true | ||
| #- rm -rf /data/classification.parquet || true | ||
| #- curl -so create_test_data.py https://raw.githubusercontent.com/ray-project/ray/releases/1.3.0/release/xgboost_tests/create_test_data.py | ||
| #- python create_test_data.py /data/classification.parquet --seed 1234 --num-rows 1000000 --num-cols 40 --num-partitions 100 --num-classes 2 |
release/rllib_tests/rllib_tests.yaml
Outdated
|
|
||
| run: | ||
| timeout: 3600 | ||
| script: unit_gpu_tests/run.sh |
There was a problem hiding this comment.
Does this work? Or do we need to use bash unit_gpu_tests/run.sh? (Is +x set automatically)?
| break | ||
|
|
||
| # Run remaining experiments. | ||
| trials = run_experiments(experiments_to_run, resume=False, verbose=2) |
There was a problem hiding this comment.
Shall we add a ray.tune.utils.release_test_util.ProgressCallback here? Then we could track some progress after kicking off. Not mandatory.
There was a problem hiding this comment.
Let's do this for the next release, then. Lot's of changes to the RLlib release tests coming up :)
| break | ||
|
|
||
| # Run remaining experiments. | ||
| trials = run_experiments(experiments_to_run, resume=False, verbose=2) |
There was a problem hiding this comment.
Shall we add a ray.tune.utils.release_test_util.ProgressCallback here? Then we could track some progress after kicking off. Not mandatory.
…b_regression_test_scripts
…b_regression_test_scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR translates all existing RLlib release tests to run with the new
Releasertool via anyscale.Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.