Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune] Add option to keep random values constant over grid search #16501

Merged
merged 3 commits into from
Jun 18, 2021

Conversation

krfricke
Copy link
Contributor

Why are these changes needed?

This introduces a new option to the BasicVariantGenerator to allow us to sample random variables before applying grid search. This will keep random variables constant across grid search categories.

Also cc @Yard1 who might be working on this code soon.

Related issue number

Closes #15126

See https://discuss.ray.io/t/tune-feature-request-using-ray-tune-for-k-fold-with-repeated-grid-sampling/2541

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@krfricke krfricke merged commit e13f0a4 into ray-project:master Jun 18, 2021
@krfricke krfricke deleted the constant-grid-search branch June 18, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tune] Support resolving grid search variables before random samples
3 participants