Same worker id in python and c++ (try #2) #16712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijrsvt
reviewed
Jun 28, 2021
There was a problem hiding this comment.
@wuisawesome
The main difference between this PR and #16568 is that this PR makes C++ the source of truth (whereas the previous attempt used Python)?
ijrsvt
reviewed
Jun 28, 2021
There was a problem hiding this comment.
@wuisawesome
The main difference between this PR and #16568 is that this PR makes C++ the source of truth (whereas the previous attempt used Python)?
|
Yup |
ijrsvt
approved these changes
Jun 28, 2021
|
From @kfstorm's comment here, I think Java already let the core worker generate the ID's, so this is really just python catching up. |
|
travis gave up https://travis-ci.com/github/ray-project/ray/builds/231132106#L1904 |
|
test failures all look like unrelated rllib tests. travis timeout also looks unrelated. merging. |
DmitriGekhtman
pushed a commit
that referenced
this pull request
Jun 28, 2021
Co-authored-by: Alex <alex@anyscale.com>
DmitriGekhtman
added a commit
that referenced
this pull request
Jun 29, 2021
This reverts commit 6aca77a.
DmitriGekhtman
pushed a commit
that referenced
this pull request
Jun 29, 2021
Co-authored-by: Alex <alex@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR makes the log files for the C++ core worker, and corresponding python worker consistent. It makes the c++ worker the only place that generates worker ids.
Related issue number
Closes #16127
Checks
scripts/format.shto lint the changes in this PR.