[Serve] Copy FastAPI ResponseModel field #16760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoakes
approved these changes
Jun 29, 2021
Comment on lines
+176
to
+177
| # If there is a response model, FastAPI creates a copy of the fields. | ||
| # But FastAPI creates the field incorrectly by missing the outer_type_. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
It turns out when you specify a response model for FastAPI, FastAPI makes a copy of that pydantic model. But when it's copying it, it missed the outer_type_ parameter. The missed parameter has no effect when you are using it in process but it is not compatible with how we serialize and copy pydantic fields in the serialization addons.
Related issue number
Closes #16757
Checks
scripts/format.shto lint the changes in this PR.