[serve] Remove unnecessary STOPPED ReplicaState #16783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiaodong
approved these changes
Jul 1, 2021
|
|
||
| def check_stopped(self) -> bool: | ||
| """Check if the actor has exited.""" | ||
| if self._stopped: | ||
| return True | ||
|
|
||
| try: | ||
| handle = ray.get_actor(self._actor_name) | ||
| ready, _ = ray.wait([self._drain_obj_ref], timeout=0) |
There was a problem hiding this comment.
What if _drain_obj_ref failed with exception ? based on what behavior of ray.wait() it will still fill up ready list with an element but we can only ensure its success via calling ray.get() ?
For this PR it's not changed however so not blocking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
STOPPEDis not actually used in the state machine, it's only set internally in the replicas.Related issue number
Checks
scripts/format.shto lint the changes in this PR.