[tune] Placement group manager fixes #16844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kai Fricke <kai@anyscale.com>
Co-authored-by: Kai Fricke <kai@anyscale.com>
6 tasks
krfricke
approved these changes
Jul 6, 2021
|
looks like tests are good. |
richardliaw
changed the title
jiaodong
pushed a commit
that referenced
this pull request
Jul 11, 2021
Co-authored-by: Kai Fricke <kai@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR fixes two major issues with placement group manager, which were uncovered during implementation of a dynamic resource allocation scheduler.
The first issue was that unusable placement groups were not being destroyed after being returned from a trial. The second issue was caused by the reconciliation method not accounting for placement groups that are unexpected, but still staged or ready.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.