Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune] use bayesopt for quick start example (which actually converges) #16997

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

krfricke
Copy link
Contributor

Why are these changes needed?

Let's actually go with bayesopt here, even if it only supports continuous search spaces. It works well for these and converges quickly.

Related issue number

Closes #13187

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krfricke krfricke merged commit fce8fa2 into ray-project:master Jul 12, 2021
@krfricke krfricke deleted the quick-example branch July 12, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1st example given in Search / Key Concepts doesn't converge and this is confusing
3 participants