[Threaded actor] Fix threaded actor race condition #19751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkooo567
added
the
@author-action-required
|
Let me fix test failures first |
scv119
reviewed
Oct 26, 2021
| @@ -768,6 +774,7 @@ CoreWorker::CoreWorker(const CoreWorkerOptions &options, const WorkerID &worker_ | |||
| void CoreWorker::Shutdown() { | |||
| io_service_.stop(); | |||
| if (options_.worker_type == WorkerType::WORKER) { | |||
| direct_task_receiver_->Stop(); | |||
There was a problem hiding this comment.
yes that's correct!
rkooo567
removed
the
@author-action-required
ericl
approved these changes
Oct 26, 2021
2 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR fixes the root cause of threaded actor thread SIGSEGV issue by properly joining the thread pool.
Basically threaded actors are executed in this way;
io_service (HandlePushTask) (post to)-> task_execution_service (post to)-> thread_pool
But our shutdown hook only stops the task_execution service, which is why there are still tasks running in the thread pool that accesses core workers instances (e.g., process & threads).
We basically stop the threadpool and join before we stop the task execution loop. In this way, we can properly waits until all threads pool operations are terminated.
I verified this fixes the segfault issues from #19746.
Related issue number
Closes #19748
Checks
scripts/format.shto lint the changes in this PR.