[RLlib] POC: Deprecate build_policy (policy template) for torch only; PPOTorchPolicy
#20061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deprecate_policy_template_torch_only
avnishn
approved these changes
Nov 5, 2021
| else: | ||
|
|
||
| def value(*args, **kwargs): | ||
| return 0.0 |
There was a problem hiding this comment.
Is this the right logic? it feels like users may want to use just advantages, and maybe advantage whitening, which still depends on the output of the value function for different timesteps in the batch. @sven1977
| @@ -25,7 +25,7 @@ | |||
| torch, _ = try_import_torch() | |||
|
|
|||
|
|
|||
| # TODO: (sven) Unify this with `build_tf_policy` as well. | |||
| # TODO: Deprecate in favor of directly sub-classing from TorchPolicy. | |||
There was a problem hiding this comment.
when you say subclassing, do you mean that we can build classes that directly inherit from torch policy, as opposed to using the policy builder model?
There was a problem hiding this comment.
oh wait thats the whole point of the PR
…deprecate_policy_template_torch_only
…deprecate_policy_template_torch_only
…deprecate_policy_template_torch_only
…deprecate_policy_template_torch_only
…deprecate_policy_template_torch_only
…deprecate_policy_template_torch_only
sven1977
added a commit
that referenced
this pull request
Nov 16, 2021
wuisawesome
pushed a commit
that referenced
this pull request
Nov 20, 2021
wuisawesome
pushed a commit
that referenced
this pull request
Nov 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC: Start deprecating
build_policy()(policy_template.py) as a means to sub-class TorchPolicy to build custom policies.build_policyis still used by most algos in RLlib (this is only a POC).TorchPolicy.lossmethod to Policy API.TODOs:
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.