Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tune] Remove unnecessary argument in update_last_result. #20653

Merged
merged 1 commit into from
Nov 23, 2021
Merged

[Tune] Remove unnecessary argument in update_last_result. #20653

merged 1 commit into from
Nov 23, 2021

Conversation

xwjiang2010
Copy link
Contributor

@xwjiang2010 xwjiang2010 commented Nov 22, 2021 •
edited
Loading

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@xwjiang2010 xwjiang2010 added this to the Tune Tech Debt Reduction milestone Nov 22, 2021
@krfricke krfricke merged commit e24c1dc into ray-project:master Nov 23, 2021
@xwjiang2010 xwjiang2010 deleted the update_last_result branch July 26, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yard1 Yard1 Yard1 approved these changes

@krfricke krfricke Awaiting requested review from krfricke

Assignees

@Yard1 Yard1

@krfricke krfricke

Labels
None yet
Projects
None yet
Milestone
Tune Tech Debt Reduction
Development

Successfully merging this pull request may close these issues.
3 participants
@xwjiang2010 @Yard1 @krfricke