Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Issue 21552: unsquash_action and clip_action (when None) cause wrong actions computed by Trainer.compute_single_action. #21553

Merged
merged 3 commits into from
Jan 12, 2022
Merged

[RLlib] Issue 21552: unsquash_action and clip_action (when None) cause wrong actions computed by Trainer.compute_single_action. #21553

merged 3 commits into from
Jan 12, 2022

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Jan 12, 2022 •
edited
Loading

#21552

  • Also enhanced the check_compute_single_action test utility function to cover the unsquash_action/clip_action=None cases.

Why are these changes needed?

#21552

Related issue number

Closes #21552

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977 sven1977 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jan 12, 2022
@sven1977 sven1977 mentioned this pull request Jan 12, 2022
Closed
2 tasks
@sven1977 sven1977 linked an issue Jan 12, 2022 that may be closed by this pull request
[RLlib] [Bug] Despite providing correct config, function returns incorrect actions #21417
Closed
2 tasks
@sven1977 sven1977 merged commit 188324c into ray-project:master Jan 12, 2022
@sven1977 sven1977 deleted the issue_21552_unsquash_actions_clip_actions branch June 2, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjoliver gjoliver gjoliver approved these changes

Assignees

@gjoliver gjoliver

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
2 participants
@sven1977 @gjoliver