Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Restore policies on eval_workers as well. #22641

Merged
merged 6 commits into from
Mar 1, 2022

Conversation

gjoliver
Copy link
Member

Why are these changes needed?

We need to restore checkpoint-ed policies on eval workers too.
Since add_policy() does it, and those policies may be used for eval purpose.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [*] Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Member

@avnishn avnishn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@sven1977 sven1977 changed the title Also restore policies on eval_workers. [RLlib] Restore policies on eval_workers as well. Feb 25, 2022
@sven1977 sven1977 merged commit e8be450 into ray-project:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants