Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][serialization] Fix registering serializer before initializing Ray. #23031

Merged
merged 5 commits into from
Mar 11, 2022

Conversation

suquark
Copy link
Member

@suquark suquark commented Mar 10, 2022

Why are these changes needed?

Fix the issue mentioned in #22984

Related issue number

Closes #22984

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@suquark
Copy link
Member Author

suquark commented Mar 11, 2022

@rkooo567 strangely, I find tests with shutdown_only still have ray initialized. do you know why? (or is this expected behavior?)

@suquark
Copy link
Member Author

suquark commented Mar 11, 2022

The CI error seems not related. I'll merge the PR.

@suquark suquark merged commit be7ccb7 into ray-project:master Mar 11, 2022
@suquark suquark deleted the fix_registering_serializer branch March 11, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core][Bug] register_serialization for custom serializers not working
2 participants