[tune] simpler get_next_trial #23396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xwjiang2010
approved these changes
Mar 22, 2022
| break | ||
| wait_for_trial = no_trials_unfinished and not self._search_alg.is_finished() | ||
| # Only fetch a new trial if we have no pending trial | ||
| if wait_for_trial or no_trials_pending: |
There was a problem hiding this comment.
if all trials are finished and search algo is finished, in the old logic, we would enter this branch. But I think it's unnecessary, as _update_trial_queue will just return False with no trial added to the queue and thus no trial selected by the scheduler_alg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
A much simpler
_update_trial_queue_and_get_next_trialwith the same functionality. The original code complicated the problem and is very hard to understand.Related issue number
Checks
scripts/format.shto lint the changes in this PR.