[Train] Test if callbacks can be deepcopied #23496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogkam
reviewed
Mar 25, 2022
There was a problem hiding this comment.
Wait @Yard1 dont we want to be testing tune callbacks as those are the ones that will be used with air? These train callbacks will eventually be deprecated.
in any case, I think ultimately we don’t want to be copying the run config at all, so deepcopy support for callbacks shouldn’t be necessary in the long run.
|
@amogkam ok, will add tests for tune ones too! |
|
Like I don't think we should require callbacks to be deepcopyable...it will no longer be necessary after #23499, right? |
|
I mean, it doesn't hurt to test for it, but I guess it will become unnecessary. @krfricke what do you think? |
|
@Yard1 should we close this? |
|
Yeah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Followup to #23333. Extends existing tests by checking if callbacks can be deepcopied.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.