[RLlib] long forgotten _hit_counts working again #23586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturNiederfahrenhorst
requested review from
sven1977,
gjoliver and
avnishn
as code owners
|
Thanks to @simonsays1980 for pointing out that he does not see it used anywhere :) |
sven1977
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The replay buffer statistic _hit_counts was introduced long ago by Eric and has neither been used in metrics, nor has it been updated on hits.
Although long forgotten, I propose to keep hit count to debug prioritized buffers or view impacts of reservoir sampling.
Code is tested, but exclude the test since it's just too trivial.
Checks
scripts/format.shto lint the changes in this PR.