Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIR] SklearnTrainer & Predictor interfaces #23803

Merged
merged 11 commits into from
Apr 11, 2022
Merged

[AIR] SklearnTrainer & Predictor interfaces #23803

merged 11 commits into from
Apr 11, 2022

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Apr 8, 2022

Why are these changes needed?

This PR adds interfaces for SklearnTrainer and SklearnPredictor.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Yard1 Yard1 added this to the Ray AIR milestone Apr 8, 2022
krfricke
krfricke approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interface LGTM

python/ray/ml/train/integrations/sklearn/sklearn_trainer.py Show resolved Hide resolved
python/ray/ml/predictors/integrations/sklearn/sklearn_predictor.py Show resolved Hide resolved
Yard1 and others added 2 commits April 9, 2022 00:06
@Yard1 @amogkam
Update python/ray/ml/predictors/integrations/sklearn/sklearn_predicto…
3751bb4 
…r.py

Co-authored-by: Amog Kamsetty <amogkam@users.noreply.github.com>
@Yard1 @amogkam
Update python/ray/ml/train/integrations/sklearn/sklearn_trainer.py
9dde502 
Co-authored-by: Amog Kamsetty <amogkam@users.noreply.github.com>
@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Apr 9, 2022
@Yard1 Yard1 removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Apr 11, 2022
@richardliaw richardliaw merged commit 40646ee into ray-project:master Apr 11, 2022
@Yard1 Yard1 deleted the sklearn_trainer_interface branch April 11, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amogkam amogkam amogkam left review comments

@ericl ericl ericl left review comments

@krfricke krfricke krfricke approved these changes

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@matthewdeng matthewdeng Awaiting requested review from matthewdeng

@richardliaw richardliaw Awaiting requested review from richardliaw

@gjoliver gjoliver Awaiting requested review from gjoliver

@simon-mo simon-mo Awaiting requested review from simon-mo

@xwjiang2010 xwjiang2010 Awaiting requested review from xwjiang2010

Assignees

@ericl ericl

@maxpumperla maxpumperla

@matthewdeng matthewdeng

@richardliaw richardliaw

@gjoliver gjoliver

@amogkam amogkam

@krfricke krfricke

@simon-mo simon-mo

@xwjiang2010 xwjiang2010

Labels
None yet
Projects
None yet
Milestone
Ray AIR
Development

Successfully merging this pull request may close these issues.
10 participants
@Yard1 @ericl @amogkam @krfricke @maxpumperla @matthewdeng @richardliaw @gjoliver @simon-mo @xwjiang2010