Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Train] Move load_checkpoint to utils #25940

Merged
merged 3 commits into from
Jun 21, 2022
Merged

[Train] Move load_checkpoint to utils #25940

merged 3 commits into from
Jun 21, 2022

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Jun 20, 2022 •
edited
Loading

Why are these changes needed?

Moves load_checkpoint methods from trainer files to util files for consistency and better modularity.

Related issue number

Closes #25567

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Yard1 Yard1 added this to the Ray AIR milestone Jun 20, 2022
xwjiang2010
xwjiang2010 approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@xwjiang2010 xwjiang2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Antoni!

amogkam
amogkam approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amogkam amogkam merged commit b7d4ae5 into ray-project:master Jun 21, 2022
@Yard1 Yard1 deleted the move_load_checkpoint_to_utils branch June 21, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xwjiang2010 xwjiang2010 xwjiang2010 approved these changes

@amogkam amogkam amogkam approved these changes

Assignees

@amogkam amogkam

@xwjiang2010 xwjiang2010

Labels
None yet
Projects
None yet
Milestone
Ray AIR
Development

Successfully merging this pull request may close these issues.

[air] move load_checkpoint to utils/ as well
3 participants
@Yard1 @amogkam @xwjiang2010