[tune] Add hook to get project/group for W&B integration #31035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikita Vemuri <nikitavemuri@gmail.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@gmail.com>
krfricke
approved these changes
Dec 13, 2022
Signed-off-by: Nikita Vemuri <nikitavemuri@gmail.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@gmail.com>
nikitavemuri
requested review from
richardliaw,
amogkam,
matthewdeng,
Yard1,
maxpumperla and
a team
as code owners
nikitavemuri
changed the title
|
Yes, good point. I updated |
krfricke
approved these changes
Dec 13, 2022
python/ray/_private/test_utils.py
Outdated
Comment on lines
1747
to
1748
| os.environ["WANDB_PROJECT_NAME"] = "test_project" | ||
| os.environ["WANDB_GROUP_NAME"] = "test_group" |
There was a problem hiding this comment.
Should we import WANDB_PROJECT_ENV_VAR and WANDB_GROUP_ENV_VAR here? (locally)
There was a problem hiding this comment.
I was seeing a ModuleNotFoundError: No module named 'pandas' error on the minimal install tests (https://buildkite.com/ray-project/oss-ci-build-pr/builds/7359#01850810-6f61-4017-82c0-f953782b0e9b) when I tried that previously because the test_utils files was importing various files from tune
There was a problem hiding this comment.
Does this happen also with local imports in the function?
Signed-off-by: Nikita Vemuri <nikitavemuri@gmail.com>
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…#31035) - Allow setting the W&B project and group environment variables from an external hook if it is not already passed to the `WandbLoggerCallback` and `setup_wandb` - Add remaining external hooks to `setup_wandb` Signed-off-by: Nikita Vemuri <nikitavemuri@gmail.com> Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
- Allow setting the W&B project and group environment variables from an external hook if it is not already passed to the `WandbLoggerCallback` and `setup_wandb` - Add remaining external hooks to `setup_wandb` Signed-off-by: Nikita Vemuri <nikitavemuri@gmail.com>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
…#31035) - Allow setting the W&B project and group environment variables from an external hook if it is not already passed to the `WandbLoggerCallback` and `setup_wandb` - Add remaining external hooks to `setup_wandb` Signed-off-by: Nikita Vemuri <nikitavemuri@gmail.com> Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
WandbLoggerCallbackandsetup_wandbsetup_wandbRelated issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.