[AIR] Rename save_checkpoints to upload_checkpoints
#31582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
krfricke
approved these changes
Jan 12, 2023
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
The name `save_checkpoints` suggests that `WandbLoggerCallback` saves checkpoints, but it doesn't; it only logs existing checkpoints to Weights and Biases. To prevent confusion, this PR renames `save_checkpoints` as `upload_checkpoints`. Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Balaji Veeramani balaji@anyscale.com
Why are these changes needed?
The name
save_checkpointssuggests thatWandbLoggerCallbacksaves checkpoints, but it doesn't; it only logs existing checkpoints to Weights and Biases. To prevent confusion, this PR renamessave_checkpointsasupload_checkpoints.Related issue number
Closes #31218
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.