Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autoscaler] Submit command #3312

Merged
merged 5 commits into from
Nov 20, 2018
Merged

[autoscaler] Submit command #3312

merged 5 commits into from
Nov 20, 2018

Conversation

richardliaw
Copy link
Contributor

@richardliaw richardliaw commented Nov 13, 2018

As requested from users.

TODO:

  • Try it out
  • Docs

Changes

This allows users to submit scripts and args to a cluster (that might not even exist yet). Closes #2970.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9327/
Test FAILed.

@richardliaw richardliaw changed the title [autoscaler][wip] Submit argument [autoscaler][wip] Submit command Nov 13, 2018
@richardliaw richardliaw changed the title [autoscaler][wip] Submit command [autoscaler] Submit command Nov 13, 2018
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9333/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9334/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9335/
Test FAILed.

@ericl ericl self-assigned this Nov 13, 2018
@@ -236,6 +236,55 @@ def attach_cluster(config_file, start, use_tmux, override_cluster_name, new):
override_cluster_name, None)


def submit_cluster(config_file, screen, tmux, stop, start,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is just sugar for rsync_up followed by an exec, why not just call those two functions instead of making this new one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, rsync_up doesn't have start cluster functionality but exec has start cluster functionality.

Ideally, you'd start, rsync, and exec.

One alternative is to do create_or_update_cluster, rsync, and then exec but it wasn't clear to me that was the cleanest way of doing things (it would create 3 different NodeUpdaters)

@ericl
Copy link
Contributor

ericl commented Nov 14, 2018 via email

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9352/
Test PASSed.

@ericl ericl merged commit c24d87b into ray-project:master Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants