Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Jobs] Fix race condition on submitting multiple jobs with the same id #33259

Merged
merged 20 commits into from
Mar 27, 2023
Merged

[Jobs] Fix race condition on submitting multiple jobs with the same id #33259

merged 20 commits into from
Mar 27, 2023

Commits on Mar 8, 2023

  1. Add env var 

    Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
    @architkulkarni
    architkulkarni committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    935f442 View commit details
    Browse the repository at this point in the history

  2. Use Ray Constants file 

    Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
    @architkulkarni
    architkulkarni committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    05c1219 View commit details
    Browse the repository at this point in the history

  3. Add docstring 

    Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
    @architkulkarni
    architkulkarni committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    42e2e3a View commit details
    Browse the repository at this point in the history

  4. Add unit test 

    Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
    @architkulkarni
    architkulkarni committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    c8f5a48 View commit details
    Browse the repository at this point in the history

  5. Add doc 

    Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
    @architkulkarni
    architkulkarni committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    5c7848a View commit details
    Browse the repository at this point in the history

  6. Add broader unit test 

    Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
    @architkulkarni
    architkulkarni committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    bfea1fd View commit details
    Browse the repository at this point in the history

  7. Fix docstring 

    Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
    @architkulkarni
    architkulkarni committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    d65eb72 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Merge branch 'master' of https://github.com/ray-project/ray into skip… 

    …-gitignore-env-var
    @architkulkarni
    architkulkarni committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    7eeef57 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. skip_gitignore -> ignore_gitignore 

    Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
    @architkulkarni
    architkulkarni committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    51dc3ad View commit details
    Browse the repository at this point in the history

  2. Update doc/source/ray-core/handling-dependencies.rst 

    Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
    @architkulkarni @angelinalg
    architkulkarni and angelinalg authored Mar 10, 2023
    Configuration menu
    Copy the full SHA
    3232925 View commit details
    Browse the repository at this point in the history

  3. Update doc/source/ray-core/handling-dependencies.rst 

    Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
    @architkulkarni @angelinalg
    architkulkarni and angelinalg authored Mar 10, 2023
    Configuration menu
    Copy the full SHA
    bda5766 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. Pipe added_num through info client 

    Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
    @architkulkarni
    architkulkarni committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    ef1f816 View commit details
    Browse the repository at this point in the history

  2. Add docstring for added_num 

    Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
    @architkulkarni
    architkulkarni committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    ea5b75a View commit details
    Browse the repository at this point in the history

  3. Make "check existence and put new info" atomic 

    Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
    @architkulkarni
    architkulkarni committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    bec92fd View commit details
    Browse the repository at this point in the history

  4. Add unit test 

    Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
    @architkulkarni
    architkulkarni committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    ddc2c92 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' of https://github.com/ray-project/ray into fix-… 

    …submission-id-race-condition
    @architkulkarni
    architkulkarni committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    9049507 View commit details
    Browse the repository at this point in the history

  6. Update docstring 

    Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
    @architkulkarni
    architkulkarni committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    cfc425f View commit details
    Browse the repository at this point in the history

  7. Return bool new_key_added 

    Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
    @architkulkarni
    architkulkarni committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    9bc357a View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Change RuntimeError to ValueError to fix test 

    Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
    @architkulkarni
    architkulkarni committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    722a104 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/ray-project/ray into fix-… 

    …submission-id-race-condition
    @architkulkarni
    architkulkarni committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    dc0f1f6 View commit details
    Browse the repository at this point in the history