[RLlib] Fixed bug in restoring a gpu trained algorithm #35024
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Apparently when you restore the torch optimizer states, the param_groups should not be converted to tensor and moved to cuda devices. (I don't think it's even necessary for the states to be moved to the device they just have to be converted to a tensor). This bug was that when someone trained an algorithm with GPU and wanted to restore for further training again on a cuda device it would yell at you saying the beta parameter in Adam optimizer should not be on cuda or should be a scalar.
This PR fixes that by separating out restoration process of
param_groups
vs.state
keys in state_dict of torch optimizers. It also adds unittests to ensure this edge case is covered in the unittests.#closes #34159
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.