-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Expand windows support comments #35715
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mattip <matti.picus@gmail.com>
jjyao
reviewed
May 24, 2023
mattip
changed the title
Expand windows support comments
[DOC] Expand windows support comments
May 24, 2023
richardliaw
reviewed
May 24, 2023
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
angelinalg
reviewed
May 25, 2023
angelinalg
reviewed
May 25, 2023
angelinalg
reviewed
May 25, 2023
angelinalg
reviewed
May 25, 2023
angelinalg
reviewed
May 25, 2023
angelinalg
reviewed
May 25, 2023
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Matti Picus <matti.picus@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Matti Picus <matti.picus@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Matti Picus <matti.picus@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Matti Picus <matti.picus@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Matti Picus <matti.picus@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Matti Picus <matti.picus@gmail.com>
angelinalg
reviewed
May 31, 2023
angelinalg
approved these changes
May 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would appreciate it if you could include two more nits. Thanks for documenting this!!
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Matti Picus <matti.picus@gmail.com>
Ping. The requested changes were made. |
YarShev
approved these changes
Jun 12, 2023
@mattip, thanks for the changes. |
Ping. This small doc change has an approval, can it be merged? |
@angelinalg is anything else needed here? |
cc @rkooo567 |
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
On the Ray slack #general channel, a user asked about windows support which led to a discussion and these qualifications about using ray on windows. Signed-off-by: NripeshN <nn2012@hw.ac.uk>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
On the Ray slack #general channel, a user asked about windows support which led to a discussion and these qualifications about using ray on windows. Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
On the Ray slack #general channel, a user asked about windows support which led to a discussion and these qualifications about using ray on windows. Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
On the Ray slack
#general
channel, a user asked about windows support which led to a discussion and these qualifications about using ray on windows.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.