Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Expand windows support comments #35715

Merged
merged 9 commits into from
Jul 18, 2023
Merged

Conversation

mattip
Copy link
Contributor

@mattip mattip commented May 24, 2023

Why are these changes needed?

On the Ray slack #general channel, a user asked about windows support which led to a discussion and these qualifications about using ray on windows.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: mattip <matti.picus@gmail.com>
@mattip mattip requested a review from a team as a code owner May 24, 2023 14:02
@mattip mattip changed the title Expand windows support comments [DOC] Expand windows support comments May 24, 2023
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
mattip and others added 6 commits May 28, 2023 10:15
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Matti Picus <matti.picus@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Matti Picus <matti.picus@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Matti Picus <matti.picus@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Matti Picus <matti.picus@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Matti Picus <matti.picus@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Matti Picus <matti.picus@gmail.com>
Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would appreciate it if you could include two more nits. Thanks for documenting this!!

Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Matti Picus <matti.picus@gmail.com>
@mattip
Copy link
Contributor Author

mattip commented Jun 12, 2023

Ping. The requested changes were made.

@YarShev
Copy link

YarShev commented Jun 12, 2023

@mattip, thanks for the changes.

@mattip
Copy link
Contributor Author

mattip commented Jul 4, 2023

Ping. This small doc change has an approval, can it be merged?

@mattip
Copy link
Contributor Author

mattip commented Jul 17, 2023

@angelinalg is anything else needed here?

@YarShev
Copy link

YarShev commented Jul 17, 2023

cc @rkooo567

@rkooo567 rkooo567 merged commit 30ce66c into ray-project:master Jul 18, 2023
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
On the Ray slack #general channel, a user asked about windows support which led to a discussion and these qualifications about using ray on windows.

Signed-off-by: NripeshN <nn2012@hw.ac.uk>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
On the Ray slack #general channel, a user asked about windows support which led to a discussion and these qualifications about using ray on windows.

Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
On the Ray slack #general channel, a user asked about windows support which led to a discussion and these qualifications about using ray on windows.

Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants