Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib-contrib] CRR #36616

Merged
merged 16 commits into from
Oct 5, 2023
Merged

[RLlib-contrib] CRR #36616

merged 16 commits into from
Oct 5, 2023

Conversation

avnishn
Copy link
Member

@avnishn avnishn commented Jun 20, 2023

Signed-off-by: Avnish avnishnarayan@gmail.com

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@avnishn
[RLlib-contrib CRR and update CRR test to used S3
78af18e 
Signed-off-by: Avnish <avnishnarayan@gmail.com>
@avnishn
Remove changes to rllib as they are unnecessary
1efb5de 
Signed-off-by: Avnish <avnishnarayan@gmail.com>
@avnishn avnishn changed the title [RLlib-contrib CRR and update CRR test to used S3 [RLlib-contrib] CRR Jun 20, 2023
@avnishn
Update s3 path
45a72aa 
Signed-off-by: Avnish <avnishnarayan@gmail.com>
@avnishn
Change dataset reading
ae87310 
Signed-off-by: Avnish <avnishnarayan@gmail.com>
@avnishn
Add example
280a116 
Signed-off-by: Avnish <avnishnarayan@gmail.com>
@stale
Copy link

stale bot commented Aug 10, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Aug 10, 2023
@sven1977 sven1977 self-assigned this Oct 3, 2023
@stale stale bot removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Oct 3, 2023
@sven1977 sven1977 added stale The issue is stale. It will be closed within 7 days unless there are further conversation rllib RLlib related issues rllib-contrib ray 2.8 rllib-oldstack-cleanup Issues related to cleaning up classes, utilities on the old API stack and removed stale The issue is stale. It will be closed within 7 days unless there are further conversation labels Oct 3, 2023
@sven1977
Merge branch 'master' into rllib_contrib_crr
96036f8 
Signed-off-by: Sven Mika <svenmika1977@gmail.com>
sven1977
sven1977 approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sven1977
wip
7bedfd0 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
4eb5273 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
Merge branch 'master' into rllib_contrib_crr
0f7c9ed 
Signed-off-by: Sven Mika <svenmika1977@gmail.com>
@sven1977
Merge branch 'master' into rllib_contrib_crr
2507d30
@sven1977
Merge branch 'master' into rllib_contrib_crr
83aee9c 
Signed-off-by: Sven Mika <svenmika1977@gmail.com>
@sven1977
wip
f357a78 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
550796e 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
Merge remote-tracking branch 'avnishn/rllib_contrib_crr' into rllib_c…
b85c0d1 
…ontrib_crr

# Conflicts:
#	.buildkite/pipeline.ml.yml
@sven1977
wip
0bf6432 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
1302885 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 merged commit d48717a into ray-project:master Oct 5, 2023
27 of 34 checks passed
Zandew pushed a commit to Zandew/ray that referenced this pull request Oct 10, 2023
@avnishn
[RLlib-contrib] CRR. (ray-project#36616)
f87da2e
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@avnishn
[RLlib-contrib] CRR. (ray-project#36616)
c8e0e41 
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sven1977 sven1977 sven1977 approved these changes

@gjoliver gjoliver Awaiting requested review from gjoliver

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

@smorad smorad Awaiting requested review from smorad

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@kouroshHakha kouroshHakha Awaiting requested review from kouroshHakha

@krfricke krfricke Awaiting requested review from krfricke

Assignees

@sven1977 sven1977

Labels
ray 2.8 rllib RLlib related issues rllib-oldstack-cleanup Issues related to cleaning up classes, utilities on the old API stack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avnishn @sven1977