Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune] Hotfix failing checkpoint test (#37220) #37305

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

krfricke
Copy link
Contributor

#37173 changed a test in a previous iteration that is failing after additional changes. This PR reverts the changes to the test to fix broken master.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

ray-project#37173 changed a test in a previous iteration that is failing after additional changes. This PR reverts the changes to the test to fix broken master.

Signed-off-by: Kai Fricke <kai@anyscale.com>
@bveeramani bveeramani merged commit fc53889 into ray-project:releases/2.6.0 Jul 11, 2023
@krfricke krfricke deleted the 2.6.0/fix-test branch September 22, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants