[train] Storage: Change class trainable save_checkpoint implementations #38554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Fricke <kai@anyscale.com>
krfricke
requested review from
sven1977,
gjoliver,
avnishn,
ArturNiederfahrenhorst,
smorad,
maxpumperla and
kouroshHakha
as code owners
added 2 commits
August 17, 2023 13:16
justinvyu
approved these changes
Aug 17, 2023
| @@ -1395,7 +1396,7 @@ def save_checkpoint(self, checkpoint_dir: str) -> Optional[Union[str, Dict]]: | |||
|
|
|||
| Returns: | |||
| A dict or string. If string, the return value is expected to be | |||
| prefixed by `checkpoint_dir`. If dict, the return value will | |||
| the `checkpoint_dir`. If dict, the return value will | |||
There was a problem hiding this comment.
Maybe we should just make the return type Optional[Dict] since we already have the string
There was a problem hiding this comment.
Good idea, will update
added 4 commits
August 17, 2023 18:54
Signed-off-by: Kai Fricke <kai@anyscale.com>
# Conflicts: # python/ray/tune/utils/release_test_util.py
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…ns (ray-project#38554) Some of our (internal) class trainables return a subpath in `save_checkpoint`. This path has been deprecated with the new storage refactor. This PR updates the implementations to reconstruct the checkpoint path in `load_checkpoint` and return None in `save_checkpoint` so adhere to the new API. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…ns (ray-project#38554) Some of our (internal) class trainables return a subpath in `save_checkpoint`. This path has been deprecated with the new storage refactor. This PR updates the implementations to reconstruct the checkpoint path in `load_checkpoint` and return None in `save_checkpoint` so adhere to the new API. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Some of our (internal) class trainables return a subpath in
save_checkpoint. This path has been deprecated with the new storage refactor. This PR updates the implementations to reconstruct the checkpoint path inload_checkpointand return None insave_checkpointso adhere to the new API.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.