Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ray 2.7 Examples][4/n]Revamp the Lightning vicuna-13b DeepSpeed fine-tuning Example #38686

Conversation

woshiyyya
Copy link
Member

@woshiyyya woshiyyya commented Aug 21, 2023

Why are these changes needed?

Revamp the vicuna-13b deepspeed finetuning example with new apis.

Release test passed: https://buildkite.com/ray-project/release-tests-pr/builds/50627#018a285e-aa32-4476-9ea2-acc9c8cf8f0b

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@woshiyyya woshiyyya changed the title [Ray 2.7 Examples][4/n] Revamp the Lightning vicuna-13b DeepSpeed fine-tuning Example [Ray 2.7 Examples][4/n][WIP] Revamp the Lightning vicuna-13b DeepSpeed fine-tuning Example Aug 21, 2023
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@woshiyyya woshiyyya marked this pull request as ready for review August 23, 2023 00:46
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@woshiyyya woshiyyya changed the title [Ray 2.7 Examples][4/n][WIP] Revamp the Lightning vicuna-13b DeepSpeed fine-tuning Example [Ray 2.7 Examples][4/n]Revamp the Lightning vicuna-13b DeepSpeed fine-tuning Example Aug 23, 2023
Signed-off-by: Yunxuan Xiao <xiaoyunxuan1998@gmail.com>
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@matthewdeng matthewdeng added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Aug 24, 2023
@zhe-thoughts zhe-thoughts merged commit 692428a into ray-project:master Aug 24, 2023
41 of 45 checks passed
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
…ne-tuning Example (ray-project#38686)

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: Yunxuan Xiao <xiaoyunxuan1998@gmail.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
LeonLuttenberger pushed a commit to jaidisido/ray that referenced this pull request Sep 5, 2023
…ne-tuning Example (ray-project#38686)

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: Yunxuan Xiao <xiaoyunxuan1998@gmail.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
…ne-tuning Example (ray-project#38686)

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: Yunxuan Xiao <xiaoyunxuan1998@gmail.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants