[data][tests] Update image classification benchmarks #38902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
raulchen
approved these changes
Aug 25, 2023
stephanie-wang
added
the
@author-action-required
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
This updates includes a few fixes for image classification benchmarks:
use Dataset.map instead of Dataset.map_batches.
[data] Implement zero-copy fusion for Read op ray-project#38789 ensures these will get fused with the Read, but map_batches also has some batch formatting overhead.
fix a bug in the benchmark related to image array dimensions
avoid a copy in the map transform
---------
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
LeonLuttenberger
pushed a commit
to jaidisido/ray
that referenced
this pull request
Sep 5, 2023
This updates includes a few fixes for image classification benchmarks:
use Dataset.map instead of Dataset.map_batches.
[data] Implement zero-copy fusion for Read op ray-project#38789 ensures these will get fused with the Read, but map_batches also has some batch formatting overhead.
fix a bug in the benchmark related to image array dimensions
avoid a copy in the map transform
---------
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
jimthompson5802
pushed a commit
to jimthompson5802/ray
that referenced
this pull request
Sep 12, 2023
This updates includes a few fixes for image classification benchmarks:
use Dataset.map instead of Dataset.map_batches.
[data] Implement zero-copy fusion for Read op ray-project#38789 ensures these will get fused with the Read, but map_batches also has some batch formatting overhead.
fix a bug in the benchmark related to image array dimensions
avoid a copy in the map transform
---------
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
This updates includes a few fixes for image classification benchmarks:
use Dataset.map instead of Dataset.map_batches.
[data] Implement zero-copy fusion for Read op ray-project#38789 ensures these will get fused with the Read, but map_batches also has some batch formatting overhead.
fix a bug in the benchmark related to image array dimensions
avoid a copy in the map transform
---------
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This updates includes a few fixes for image classification benchmarks:
Dataset.mapinstead ofDataset.map_batches. [data] Implement zero-copy fusion for Read op #38789 ensures these will get fused with the Read, butmap_batchesalso has some batch formatting overhead.Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.