Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][clusters] Change title of RayService doc to Deploy Ray Serve Apps #39641

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

angelinalg
Copy link
Contributor

Why are these changes needed?

This doc title is a too general. Ideally, each user guide title represents some kind of user tasks they want accomplish.
cc: @scottsun94 @gvspraveen @richardliaw

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
@angelinalg angelinalg added docs An issue or change related to documentation core-clusters For launching and managing Ray clusters/jobs/kubernetes labels Sep 13, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a minor note, I saw that this doc follows a similar format as the RayService Quickstart, wondering if we want to unify the naming there as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like Deploy Serve Apps Quickstart?

@matthewdeng matthewdeng merged commit 1225d52 into ray-project:master Sep 13, 2023
13 of 15 checks passed
@angelinalg angelinalg deleted the serve-apps-kuberay branch September 13, 2023 22:04
angelinalg added a commit to angelinalg/ray that referenced this pull request Sep 14, 2023
…pps (ray-project#39641)

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
GeneDer pushed a commit that referenced this pull request Sep 14, 2023
* [Doc] Fix Title of the Transformers GLUE example (#39605)

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>

* [docs][train]Make Train example titles, heading more consistent (#39606)

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Co-authored-by: Yunxuan Xiao <xiaoyunxuan1998@gmail.com>
Co-authored-by: matthewdeng <matthew.j.deng@gmail.com>

* [docs][clusters] Change title of RayService doc to Deploy Ray Serve Apps (#39641)

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>

---------

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Co-authored-by: Yunxuan Xiao <yunxuanx@anyscale.com>
Co-authored-by: Yunxuan Xiao <xiaoyunxuan1998@gmail.com>
Co-authored-by: matthewdeng <matthew.j.deng@gmail.com>
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Sep 15, 2023
…pps (ray-project#39641)

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
…pps (ray-project#39641)

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-clusters For launching and managing Ray clusters/jobs/kubernetes docs An issue or change related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants