Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Deprecate Reader #40196

Merged
merged 8 commits into from
Nov 2, 2023
Merged

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Oct 6, 2023

Why are these changes needed?

tl;dr Reader adds unnecessary complexity, so we're removing it.

We're deprecating Reader and moving its methods into Datasource. There are several reasons why:

  1. Reader introduces a pass-through layer.
class FileBasedDatasource(Datasource):
    def create_reader(self, **kwargs):
        return _FileBasedDatasourceReader(self, **kwargs)
  1. Reader subclasses contain circular dependencies.
  1. Datasource parameters are specified with implicit (and error-prone) keywords arguments. For example:
    read_options = reader_args.pop(
    "read_options", csv.ReadOptions(use_threads=False)
    )
    parse_options = reader_args.pop("parse_options", csv.ParseOptions())

Going forward, you would implement Datasource.get_read_tasks and Datasource.estimate_inmemory_size directly rather than Reader.get_read_tasks and Reader.estimate_inmemory_size.

This change is part of a larger effort to clean up the Datasource-related interfaces. For more information, see the design document.

Related issue number

Towards #40296

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@stephanie-wang
Copy link
Contributor

Can you provide some context in the PR description?

Copy link
Contributor

@stephanie-wang stephanie-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, modulo the TODOs!

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani marked this pull request as ready for review November 2, 2023 04:25
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani merged commit 4f2386e into ray-project:master Nov 2, 2023
22 of 28 checks passed
@bveeramani bveeramani deleted the deprecate-reader branch November 2, 2023 18:45
bveeramani added a commit that referenced this pull request Nov 3, 2023
This PR is part of a larger effort to clean up the Datasource interfaces. #40196 deprecated Reader. Accordingly, this PR removes _TorchDatasourceReader and _HuggingFaceDatasourceReader and moves their logic into the respective datasources.

For more information, see https://docs.google.com/document/d/1Bqhbzvxv7liwpOhyBzRVy5tOzXdy-NiMSFa-6hupr18/edit#heading=h.rytitv546vx5.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
bveeramani added a commit that referenced this pull request Nov 3, 2023
This PR is part of a larger effort to clean up the Datasource interfaces. #40196 deprecated Reader. Accordingly, this PR removes _RangeDatasourceReader and moves it's logic into RangeDatasource.

For more information, see https://docs.google.com/document/d/1Bqhbzvxv7liwpOhyBzRVy5tOzXdy-NiMSFa-6hupr18/edit#heading=h.rytitv546vx5.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
bveeramani added a commit that referenced this pull request Nov 3, 2023
This PR is part of a larger effort to clean up the Datasource interfaces. #40196 deprecated Reader. Accordingly, this PR removes Reader implementations for Mongo, BigQuery, Databricks, and SQL, and moves their logic into the respective datasources.

For more information, see https://docs.google.com/document/d/1Bqhbzvxv7liwpOhyBzRVy5tOzXdy-NiMSFa-6hupr18/edit#heading=h.rytitv546vx5.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
bveeramani added a commit that referenced this pull request Nov 6, 2023
This PR is part of a larger effort to clean up the Datasource interfaces. #40196 deprecated Reader. Accordingly, this PR removes _FileBasedDatasourceReader and updates the FileBasedDatasource subclasses.

For more information, see https://docs.google.com/document/d/1Bqhbzvxv7liwpOhyBzRVy5tOzXdy-NiMSFa-6hupr18/edit#heading=h.rytitv546vx5.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Nov 29, 2023
tl;dr: Reader adds unnecessary complexity, so we're removing it.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Nov 29, 2023
This PR is part of a larger effort to clean up the Datasource interfaces. ray-project#40196 deprecated Reader. Accordingly, this PR removes _TorchDatasourceReader and _HuggingFaceDatasourceReader and moves their logic into the respective datasources.

For more information, see https://docs.google.com/document/d/1Bqhbzvxv7liwpOhyBzRVy5tOzXdy-NiMSFa-6hupr18/edit#heading=h.rytitv546vx5.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Nov 29, 2023
This PR is part of a larger effort to clean up the Datasource interfaces. ray-project#40196 deprecated Reader. Accordingly, this PR removes _RangeDatasourceReader and moves it's logic into RangeDatasource.

For more information, see https://docs.google.com/document/d/1Bqhbzvxv7liwpOhyBzRVy5tOzXdy-NiMSFa-6hupr18/edit#heading=h.rytitv546vx5.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Nov 29, 2023
…40826)

This PR is part of a larger effort to clean up the Datasource interfaces. ray-project#40196 deprecated Reader. Accordingly, this PR removes Reader implementations for Mongo, BigQuery, Databricks, and SQL, and moves their logic into the respective datasources.

For more information, see https://docs.google.com/document/d/1Bqhbzvxv7liwpOhyBzRVy5tOzXdy-NiMSFa-6hupr18/edit#heading=h.rytitv546vx5.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Nov 29, 2023
This PR is part of a larger effort to clean up the Datasource interfaces. ray-project#40196 deprecated Reader. Accordingly, this PR removes _FileBasedDatasourceReader and updates the FileBasedDatasource subclasses.

For more information, see https://docs.google.com/document/d/1Bqhbzvxv7liwpOhyBzRVy5tOzXdy-NiMSFa-6hupr18/edit#heading=h.rytitv546vx5.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants