-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] [rllib] Remove outdated RLlib examples from the docs 1/N #41472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
angelinalg
requested review from
sven1977,
avnishn,
ArturNiederfahrenhorst,
smorad,
maxpumperla,
kouroshHakha and
a team
as code owners
November 29, 2023 02:15
angelinalg
changed the title
[docs] [rllib] Remove outdated RLlib examples from the docs
WIP [docs] [rllib] Remove outdated RLlib examples from the docs
Nov 29, 2023
sven1977
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @angelinalg
sven1977
reviewed
Nov 29, 2023
@@ -1884,24 +1884,6 @@ py_test( | |||
args = ["--stop-iter=2", "--framework=torch"] | |||
) | |||
|
|||
py_test( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to also remove from this file: test_env_with_subprocess
.
Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
angelinalg
changed the title
WIP [docs] [rllib] Remove outdated RLlib examples from the docs
[docs] [rllib] Remove outdated RLlib examples from the docs
Nov 30, 2023
angelinalg
changed the title
[docs] [rllib] Remove outdated RLlib examples from the docs
[docs] [rllib] Remove outdated RLlib examples from the docs 1/N
Nov 30, 2023
pcmoritz
approved these changes
Dec 7, 2023
angelinalg
added a commit
to angelinalg/ray
that referenced
this pull request
Dec 8, 2023
…project#41472) Removing outdated examples. cc: @sven1977 Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com> --------- Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Co-authored-by: Sven Mika <svenmika1977@gmail.com>
angelinalg
added
rllib
RLlib related issues
docs
An issue or change related to documentation
v2.9.0-pick
labels
Dec 8, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing outdated examples.
cc: @sven1977
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.