Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] [rllib] Remove outdated RLlib examples from the docs 1/N #41472

Merged
merged 8 commits into from Dec 7, 2023

Conversation

angelinalg
Copy link
Contributor

Removing outdated examples.
cc: @sven1977

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
@angelinalg angelinalg changed the title [docs] [rllib] Remove outdated RLlib examples from the docs WIP [docs] [rllib] Remove outdated RLlib examples from the docs Nov 29, 2023
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @angelinalg

@@ -1884,24 +1884,6 @@ py_test(
args = ["--stop-iter=2", "--framework=torch"]
)

py_test(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to also remove from this file: test_env_with_subprocess.

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
@angelinalg angelinalg changed the title WIP [docs] [rllib] Remove outdated RLlib examples from the docs [docs] [rllib] Remove outdated RLlib examples from the docs Nov 30, 2023
@angelinalg angelinalg changed the title [docs] [rllib] Remove outdated RLlib examples from the docs [docs] [rllib] Remove outdated RLlib examples from the docs 1/N Nov 30, 2023
@pcmoritz pcmoritz merged commit 87cf410 into ray-project:master Dec 7, 2023
32 of 38 checks passed
@angelinalg angelinalg deleted the remove-rllib-ex branch December 8, 2023 04:03
angelinalg added a commit to angelinalg/ray that referenced this pull request Dec 8, 2023
…project#41472)

Removing outdated examples.
cc: @sven1977

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>

---------

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Co-authored-by: Sven Mika <svenmika1977@gmail.com>
@angelinalg angelinalg added rllib RLlib related issues docs An issue or change related to documentation v2.9.0-pick labels Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs An issue or change related to documentation rllib RLlib related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants