[Serve] Improve handling the websocket server disconnect scenario #42130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sihan Wang <sihanwang41@gmail.com>
GeneDer
reviewed
Jan 2, 2024
edoakes
reviewed
Jan 3, 2024
python/ray/serve/_private/proxy.py
Outdated
Comment on lines
1043
to
1046
| # If the server disconnects, status_code can be set above from the | ||
| # disconnect message. but it is not guaranteed. | ||
| # If client disconnects, the disconnect code comes from | ||
| # a client message via the receive interface, but is is not guaranteed. |
There was a problem hiding this comment.
please fix grammar and punctuation
edoakes
reviewed
Jan 3, 2024
|
GeneDer
approved these changes
Jan 4, 2024
| @@ -547,6 +550,66 @@ async def test_proxy_asgi_receive(self): | |||
|
|
|||
| queue.close.assert_called_once() | |||
|
|
|||
| @pytest.mark.asyncio | |||
| @pytest.mark.parametrize( | |||
| "disconnect", | |||
There was a problem hiding this comment.
Nitpick (non-blocker): We can probably refactor this to pass a tuple of received messages and expected messages so we don't need to do have the if-else statement below. Just an idea, no strong feeling either way.
edoakes
approved these changes
Jan 7, 2024
sihanwang41
added a commit
to sihanwang41/ray
that referenced
this pull request
Jan 8, 2024
…y-project#42130) Server disconnect message is not guaranteed to be sent. So we need to handle it when finish the websocket connection. --------- Signed-off-by: Sihan Wang <sihanwang41@gmail.com>
8 tasks
vickytsang
pushed a commit
to ROCm/ray
that referenced
this pull request
Jan 12, 2024
…y-project#42130) Server disconnect message is not guaranteed to be sent. So we need to handle it when finish the websocket connection. --------- Signed-off-by: Sihan Wang <sihanwang41@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Server disconnect message is not guaranteed to be sent. So we need to handle it when finish the websocket connection.
Related issue number
Closes: #42124
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.