[Data] Retry write if error during file clean up #42326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
bveeramani
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
raulchen,
stephanie-wang and
Zandew
as code owners
bveeramani
commented
Jan 11, 2024
Comment on lines
+88
to
+90
| def open_output_stream(self, path: str) -> "pyarrow.NativeFile": | ||
| return self.filesystem.open_output_stream(path, **self.open_stream_args) | ||
|
|
There was a problem hiding this comment.
Introduced this method as a seam for testing
bveeramani
added a commit
to bveeramani/ray
that referenced
this pull request
Jan 11, 2024
We already do retries if an error happens during the actual write or when a file is opened. But, you can get an error when the file closes (specifically, when the NativeFile context closes), and that isn't retried. To fix this issue, this PR updates our logic to increase the scope of retries. Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
8 tasks
can-anyscale
pushed a commit
that referenced
this pull request
Jan 11, 2024
We already do retries if an error happens during the actual write or when a file is opened. But, you can get an error when the file closes (specifically, when the NativeFile context closes), and that isn't retried. To fix this issue, this PR updates our logic to increase the scope of retries. Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
vickytsang
pushed a commit
to ROCm/ray
that referenced
this pull request
Jan 12, 2024
We already do retries if an error happens during the actual write or when a file is opened. But, you can get an error when the file closes (specifically, when the NativeFile context closes), and that isn't retried. To fix this issue, this PR updates our logic to increase the scope of retries. Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We already do retries if an error happens during the actual write or when a file is opened. But, you can get an error when the file closes (specifically, when the
NativeFilecontext closes), and that isn't retried.To fix this issue, this PR updates our logic to increase the scope of retries.
Related issue number
Fixes #42287
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.